Fix OptionGroup type now that schema has more properties
#1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it's actually based on keys defined in the `groups` array, which is more appropriate, rather than assuming "all required props." This is possible by switching the `groups` type to a `satisfies` clause, which wasn't available when the code was first written.
CarsonF
force-pushed
the
bugfix/option-type
branch
from
9e8b43c to
05f760b
Compare
adam-soltech
pushed a commit
that referenced
this pull request
Oct 31, 2023
Now it's actually based on keys defined in the groups array, which is more appropriate, rather than assuming "all required props." This is possible by switching the groups type to a satisfies clause, which wasn't available when the code was first written.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it's actually based on keys defined in the
groupsarray, which is more appropriate, rather than assuming "all required props."This is possible by switching the
groupstype to asatisfiesclause, which wasn't available when the code was first written.